Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use Map for tags for AWS secrets manager and kms #1055

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

fix: use Map for tags for AWS secrets manager and kms #1055

wants to merge 9 commits into from

Conversation

usmansaleem
Copy link
Contributor

@usmansaleem usmansaleem commented Jan 28, 2025 •
edited
Loading

PR Description

Fixed Issue(s)

fixes #1052

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Testing

  • I thought about testing these changes in a realistic/non-local environment.

@usmansaleem usmansaleem changed the title wip - Use Map for tags for AWS secrets manager and kms fix: use Map for tags for AWS secrets manager and kms Jan 30, 2025
@usmansaleem usmansaleem added the doc-change-required Indicates an issue or PR that requires doc to be updated label Jan 30, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2025 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@usmansaleem
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@usmansaleem
Copy link
Contributor Author

recheck

@usmansaleem usmansaleem marked this pull request as ready for review January 30, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc-change-required Indicates an issue or PR that requires doc to be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect tag filter application for AWS KMS in eth1 mode
1 participant
@usmansaleem