Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 3738 download and attach agent #120

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

BrianPhillips2020
Copy link
Contributor

@BrianPhillips2020 BrianPhillips2020 commented Dec 13, 2024

In this PR

  • Adds InstallAgentTask which downloads the agent if one is not supplied and can attach the agent to specified tasks (in this case hardcoded to Test tasks) via java args.
  • Adds ContrastConfigurationExtension
  • Update READMEs
  • Add EndToEndTests which require gradle properties to run to avoid accidentally hammering TS with requests for new agents

TODO (tickets linked if exist)

  • Figure out specifics for how the agent should be attached to running tests. Auto attach when tests run? Configured to attach to supplied tasks? Require property to attach or to not attach? JAVA-8882
  • Manual testing shows the agent does not start when attached to tests due to failing to retrieve ServerSettings from TS, investigate and fix
  • Provide configuration option for allowing extra Contrast Configurations JAVA-8887
  • Configure Proxy for SDK JAVA-8883
  • Implement real logging, requires redesigning one test JAVA-8885

@BrianPhillips2020
Copy link
Contributor Author

Manual testing shows the agent does not start when attached to tests due to failing to retrieve ServerSettings from TS, investigate and fix

I still don't know why this is happening yet. I think it's because my test was running with /api at the end of the url I was providing to my ts instance, and server settings is just trying to reach the normal serverSettings endpoint but with /api in the middle of it and getting confused. I'm gonna try to fix

@BrianPhillips2020
Copy link
Contributor Author

Manual testing shows the agent does not start when attached to tests due to failing to retrieve ServerSettings from TS, investigate and fix

I still don't know why this is happening yet. I think it's because my test was running with /api at the end of the url I was providing to my ts instance, and server settings is just trying to reach the normal serverSettings endpoint but with /api in the middle of it and getting confused. I'm gonna try to fix

This was it, lol. The agent was using the same configurations I provided to the SDK, which hits similar endpoints but requires that /api appended to the urls.

@BrianPhillips2020 BrianPhillips2020 force-pushed the JAVA-3738-download-and-attach-agent branch from 3c54035 to c33547a Compare December 17, 2024 14:20
@BrianPhillips2020 BrianPhillips2020 merged commit 5ae7fc3 into main Dec 17, 2024
4 checks passed
@BrianPhillips2020 BrianPhillips2020 deleted the JAVA-3738-download-and-attach-agent branch December 17, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants