Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

work on getting all the embedded screens from a root screen #3155

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shroffk
Copy link
Member

@shroffk shroffk commented Oct 3, 2024

Not necessarily very happy with the structure of the code and am quite happy for input

@shroffk shroffk requested a review from georgweiss October 3, 2024 20:59
Copy link
Collaborator

@georgweiss georgweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this change add an API to spot all embedded displays, there is still some processing to perform. Patching pv_name in all files is not sufficient, the parent file referencing the embedded display must be updated to reference the patched bob file.

@shroffk
Copy link
Member Author

shroffk commented Dec 18, 2024

@georgweiss what is the future of this PR
We wanted to morph this project into something which would provide a service to do various .bob file evaluations.

@georgweiss
Copy link
Collaborator

I'm afraid that with a non-trivial structure of bob files referencing resources in other parts of the file system, only a deep copy of substantial parts of the file system would be needed. Not being able to access resources will make the display look broken and that in my view defeats the purpose of "replaying" a display.

We've discussed background screen recording as an alternative, in particular as stakeholders claim the use case is about quite recent events in the OPI rather than replaying something in a more distant past.

For the time being we can put this on hold.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants