Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Documentation for FORA, NPR-2p, and FOMC Corpus and Update Related Datasets and Config Files #238

Merged
merged 16 commits into from
Nov 14, 2024

Conversation

yash-chatha
Copy link
Contributor

@yash-chatha yash-chatha commented Oct 19, 2024

Description
I added the fora.rst file with detailed documentation for the FORA Corpus, ensuring that it is properly reflected in the ConvoKit website. In addition, I updated the datasets.rst file to include the FORA dataset, and made necessary changes to the download_config.json file to ensure the correct handling and downloading of the dataset. I did the same for the NPR-2p and FOMC corpuses. All files now should have working links to their respective conversion notebooks.

Motivation and Context
This change is required to integrate the new FORA Corpus into the ConvoKit website's documentation and ensure that it can be downloaded and utilized by users, as well as adding the NPR-2p and FOMC corpuses from the previous PR. This update solves the problem of incomplete dataset documentation and configuration by ensuring that the new corpus is fully supported.

How has this been tested?
These changes were tested by verifying that the documentation renders correctly in the local development environment and by confirming that the updates to the configuration file allow for successful dataset download. I ran tests locally to ensure that these changes did not interfere with existing functionality. I also verified through the index.html files reflected all changes as expected.

Other information
N/A

@seanzhangkx8 seanzhangkx8 merged commit d1dcc52 into CornellNLP:master Nov 14, 2024
5 checks passed
@seanzhangkx8
Copy link
Collaborator

@all-contributors please add @yash-chatha for Documentation, Examples

Copy link
Contributor

@seanzhangkx8

I've put up a pull request to add @yash-chatha! 🎉

@seanzhangkx8
Copy link
Collaborator

@all-contributors please add @laerdon for Documentation, Examples

Copy link
Contributor

@seanzhangkx8

I've put up a pull request to add @laerdon! 🎉

@seanzhangkx8
Copy link
Collaborator

@all-contributors please add @laerdon for Documentation, Examples
@all-contributors please add @yash-chatha for Documentation, Examples

Copy link
Contributor

@seanzhangkx8

I've put up a pull request to add @laerdon! 🎉

@seanzhangkx8
Copy link
Collaborator

@all-contributors please add @yash-chatha for Documentation, Examples

Copy link
Contributor

@seanzhangkx8

I've put up a pull request to add @yash-chatha! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants