Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added selection filter for random speaker/conversation/utterance corpus functions #268

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Added selection filter for random speaker/conversation/utterance corpus functions #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
65d5986
Edited functions of corpus module-- random speaker, random_conversati…
wasihussain914 Jan 2, 2025
946eb8b
run formatter
seanzhangkx8 Jan 3, 2025
5510adf
rerun formatter
seanzhangkx8 Jan 3, 2025
27eaac5
Added check in random object for no selector
wasihussain914 Jan 3, 2025
b4baa3d
Merge branch 'feature/randomSelection' of https://github.com/soulking…
wasihussain914 Jan 3, 2025
97abf9a
Black formatting
wasihussain914 Jan 3, 2025
05c43db
update random obj functions
seanzhangkx8 Jan 6, 2025
4a46429
rerun formatter
seanzhangkx8 Jan 7, 2025
a877d4b
Edited docs for itterance functions.
wasihussain914 Jan 19, 2025
1dc6384
Merge branch 'feature/randomSelection' of https://github.com/soulking…
wasihussain914 Jan 19, 2025
a351a5e
Final edit of docs after running black
wasihussain914 Jan 19, 2025
a64a5e5
final commit with black run
wasihussain914 Jan 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions convokit/coordination/coordination.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,9 +486,10 @@ def _scores_over_utterances(
target = utt1.speaker
if speaker == target:
continue
speaker, target = Coordination._annot_speaker(
speaker, utt2, split_by_attribs
), Coordination._annot_speaker(target, utt1, split_by_attribs)
speaker, target = (
Coordination._annot_speaker(speaker, utt2, split_by_attribs),
Coordination._annot_speaker(target, utt1, split_by_attribs),
)

speaker_filter = speaker_utterance_selector(utt2, utt1)
target_filter = target_utterance_selector(utt2, utt1)
Expand Down
Loading
Loading