Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline must_deserialize/may_deserialize and improve error message #63

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

webmaster128
Copy link
Member

Closes #3

@webmaster128 webmaster128 force-pushed the inline-must_deserialize branch from b500d63 to e829919 Compare November 12, 2023 00:21
@webmaster128 webmaster128 added this to the 1.2 milestone Nov 12, 2023
Copy link
Contributor

@maurolacy maurolacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

from_slice(&value)
} else {
let object_info = not_found_object_info::<T>(self.storage_key);
Err(StdError::not_found(object_info))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 Nice improvement.

@webmaster128 webmaster128 force-pushed the inline-must_deserialize branch from e829919 to ad01fb5 Compare November 13, 2023 11:38
@webmaster128 webmaster128 merged commit 4f66ce4 into release/1.2 Nov 13, 2023
1 of 2 checks passed
@webmaster128 webmaster128 deleted the inline-must_deserialize branch November 13, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants