Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor build address cmd #2101

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Refactor build address cmd #2101

merged 1 commit into from
Jan 21, 2025

Conversation

pinosu
Copy link
Contributor

@pinosu pinosu commented Jan 21, 2025

No description provided.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 43.02%. Comparing base (939a837) to head (95d1085).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
x/wasm/client/cli/query.go 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2101      +/-   ##
==========================================
+ Coverage   42.99%   43.02%   +0.02%     
==========================================
  Files          85       85              
  Lines       11601    11606       +5     
==========================================
+ Hits         4988     4993       +5     
  Misses       6166     6166              
  Partials      447      447              
Files with missing lines Coverage Δ
x/wasm/keeper/querier.go 77.41% <100.00%> (+0.14%) ⬆️
x/wasm/client/cli/query.go 0.00% <0.00%> (ø)

Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record: this change was needed to avoid an unused query connection to a node

@pinosu pinosu merged commit 5b1b179 into main Jan 21, 2025
19 checks passed
@pinosu pinosu deleted the refactor_build_addres_cmd branch January 21, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants