-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add composite keys, array support, and convert project to TypeScript #28
Open
jordansoltman
wants to merge
25
commits into
CoursePark:master
Choose a base branch
from
jordansoltman:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed eslint to just run on specs
I removed Node 0.X from travis as jasmine doesn't support running tests on it anymore: https://github.com/jasmine/jasmine/blob/master/release_notes/3.0.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realize this pull request is attempting a huge amount of changes in one go, but I'll submit the request for your consideration regardless if you choose to merge.
This restructures the library, and adds some major functionality while maintaining backwards compatibility.
Additions / Bug Fixes
TypeScript
The project has been converted to TypeScript to simplify development, and as a side-effect produce a TypeScript definition file.
npm run build
builds the source tolib/
.eslint
is abandoned fortslint
for the source files, still run withnpm run lint
.eslint
is however still used for the spec files until (if) they ever get converted to TypeScript, now linted withnpm run lint-specs
.Composite Keys
My main purpose for forking was to add support for composite keys. For example, below both a and b together form the primary key of my data. There was no way to get a result shown below:
This also happens to fix a bug that exists in the current version. If the key for the root isn't the first column, it fails:
I also wanted to tackle the array issue #13 so I added support for an array flag that can be set to true. This will then cause the values for that column to aggregate in an array.
Testing
I added more tests, and all existing tests pass.