Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix transforms #1512

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Matrix transforms #1512

wants to merge 11 commits into from

Conversation

david-yz-liu
Copy link
Contributor

Proposed Changes

(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)

This PR adds new parsers for all types of transformations in SVG files, specifically it adds parsers for matrix, rotate, scale, skewX, and skewY. After parsing the SVG transformations, they are represented as matrices.

How I tested my changes:

  • for rotate, scale, skewX, and skewY, I added some arbitrary transformations to the existing Computer Science graph, and I checked that they were displayed accordingly on the courseography graph page after parsing them
  • for matrix, I checked that the result remained unvaried when I substituted each of the of the other transformations for their corresponding matrix equivalent.

Follow-up of #1475.

Screenshots of your changes (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change) X
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.
  • I have updated the project Changelog (this is required for all changes).

After opening your pull request:

  • I have verified that the CircleCI checks have passed.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 993a983e-fc93-4d1e-b7db-04f9951efadd

Details

  • 0 of 118 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-11.6%) to 34.32%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/Svg/Builder.hs 0 33 0.0%
app/Svg/Parser.hs 0 85 0.0%
Totals Coverage Status
Change from base Build 6c8565e1-084f-40f1-909b-165579817bd9: -11.6%
Covered Lines: 533
Relevant Lines: 1502

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants