Inventory Holder #195
Open
Inventory Holder #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the title that is stored inside of the inventory holder instead of having to constantly convert between component and text. This should be a bit more performant.
Switch to partial match as the title contains page numbers.
Cancel the click even at the start reducing the chance that errors allow players to get free items.
|
Don't use the legacy ampersand methods or go from string->component etc. You can just use the deprecated method to create inventories with a string option. It serves no purpose to convert from string->component. We still only support legacy color codes (and it'll be that way for a while), and the deprecated methods aren't going anywhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement inventory holder:
Use the title stored within the holder to determine the menu type.
Move the event cancellation to the top of the listener that the event is still cancelled, even if the GUI type checks fail.