Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(falcon_discover): allow duplicate hostnames to be listed #551

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

carlosmmatos
Copy link
Contributor

Fixes #550

This PR adds a new option allow_duplicates that will allow the user to display all hosts with the same hostname, differentiated by Asset ID from the Discover API.

Example:
You have the following hosts in your environment:

  • example-host1
  • example-host1
    If you set allow_duplicates: true then you will see:
  • example-host1
  • example-host1_fkjlajksdlfjalsdjflkjlasdjflkj_jsdljkfalkjsdlfkja

Fixes CrowdStrike#550

This PR adds a new option `allow_duplicates` that will allow the user to
display all hosts with the same hostname, differentiated by Asset ID
from the Discover API.
@carlosmmatos carlosmmatos added the minor_changes New features, like plugin or module options label Aug 29, 2024
@carlosmmatos carlosmmatos added this to the 4.6.0 milestone Aug 29, 2024
@carlosmmatos carlosmmatos self-assigned this Aug 29, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 39.59%. Comparing base (f81d16b) to head (bf2e2df).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
plugins/inventory/falcon_discover.py 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #551      +/-   ##
==========================================
+ Coverage   38.93%   39.59%   +0.65%     
==========================================
  Files          23       24       +1     
  Lines        1179     1220      +41     
  Branches      211      216       +5     
==========================================
+ Hits          459      483      +24     
- Misses        719      736      +17     
  Partials        1        1              
Flag Coverage Δ
sanity 39.59% <0.00%> (+0.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@carlosmmatos carlosmmatos merged commit f8ee0d8 into CrowdStrike:main Aug 30, 2024
6 checks passed
@carlosmmatos carlosmmatos deleted the carlosmmatos/issue550 branch August 30, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor_changes New features, like plugin or module options
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to view duplicate host in discover inventory
3 participants