family life gift card app #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
able to generate now and proper auth on the admin for issuances - no editing issuance after gift cards are created
various other fixes and progress towards issuing and displaying gift cards
store gift card type on each gift card
we don't use sidekiq but it's already set up in terraform and could be used in the future, so it's good to have
knutsenm
requested changes
Jan 24, 2025
…-cards into rails_7_rebase
since we're still creating official dbs
various config change suggestions Co-authored-by: Mark Knutsen <[email protected]>
fix filter on column that doesn't exist any more remove some sidekiq refs
knutsenm
approved these changes
Feb 3, 2025
| @@ -0,0 +1,8 @@ | |||
| class MonitorsController < ApplicationController | |||
| # skip_before_action :require_login, raise: false | |||
There was a problem hiding this comment.
Interesting; that skip isn't needed? In which case this comment can go away.
There was a problem hiding this comment.
Right, I copied that from one-app but campaign forms doesn't have it either. We don't need it here because there is no login_required filter, because the site is only active admin stuff, and active admin has its own login filter.
app/views/login/error.html.erb
Outdated
| @@ -0,0 +1,10 @@ | |||
| <!-- because of https://github.com/omniauth/omniauth/wiki/Resolving-CVE-2015-9284, we need to do a post to /auth/oktaoauth, so this page will do it seamlessly without being visible to the user --> | |||
There was a problem hiding this comment.
Is this comment relevant here? Looks to be copied from the new.html.erb
tweak data info comment to not have has_access boolean Co-authored-by: Mark Knutsen <[email protected]>
…-cards into rails_7_rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.