EP-2354 - branded checkout changes #1121
Conversation
…ly, and show it when button is clicked.
wjames111
force-pushed
the
EP-2354-branded-checkout-changes
branch
from
a71f602 to
d7840e0
Compare
…nded-checkout-changes
|
@wrandall22 does this look like what you were asking? I removed logic and references for hideSpouseDetails and left showSpouseDetails toggle button and logic. |
wjames111
added
the
On Staging
|
I believe there is some JS logic around the button as well. |
|
Oh my mistake, I thought we were leaving the |
branded-checkout.html
Outdated
| @@ -11,7 +11,7 @@ | |||
| </head> | |||
| <body> | |||
|
|
|||
| <branded-checkout designation-number="2294554" show-cover-fees="true" use-v3="true" ng-cloak></branded-checkout> | |||
| <branded-checkout designation-number="2294554" show-cover-fees="true" use-v3="true" ng-cloak hide-spouse-details="true" hide-annual="true" hide-quarterly="true"></branded-checkout> | |||
There was a problem hiding this comment.
Let's not commit this change.
| <div ng-if="$ctrl.compactAddress"> | ||
| <div class="col-sm-3"> | ||
| <div class="form-group is-required" ng-class="{'has-error': ($ctrl.parentForm.addressRegion | showErrors) || $ctrl.loadingRegionsError}"> | ||
| <label translate>{{'STATE'}}</label> |
There was a problem hiding this comment.
Can you update the label structure to match the non-compact address version for accessibility?
|
Between 550px and 710px, the labels are too long (not sure how many devices fit into this range, but I see the iPhone SE 2nd Gen seems to) 
|
|
@wrandall22 what are you thinking for label length? We could scale down all label sizes, remove additional label names or we could add nowrap or something (probably a bad idea) |
|
One option would be to use |
Primary task highlighted in JIra ticket EP-2527, Update Name of Card # to Card Number. Update includes layout changes to the standard checkout, which we'll need to decide whether to make this change across the board or specifically on the new version.