-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EP-2362] Implement left panel/header from design #1148
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking amazing! Thank you for making this so good. I just had a few comments.
The "Powered by Okta" text is more faded out on the design.
During responsive testing, when I get to 380 px (some phones), the background image doesn't go all the way down to the button of the div and the text prob needs to get smaller.
You could fix this by changing the image to a background image.
background: url("/assets/img/register-account-header.jpeg");
background-position-x: 0%;
background-position-y: 0%;
background-size: auto;
background-size: cover;
background-position: center;
}
@dr-bizz I mentioned to Ryan that the contrast didn't pass WCAG guidelines, and he updated it in one of the screens but not all of them. |
@dr-bizz I opted to not use a background image because the layout was easier to implement if the image takes up space in the desktop view. I adjusted the styles to fill the whole vertical area even at very small screen widths. |
Can confirm contrast issue.
…On Mon, Feb 10, 2025 at 3:54 PM Caleb Cox ***@***.***> wrote:
The "Powered by Okta" text is more faded out on the design.
@dr-bizz <https://github.com/dr-bizz> I mentioned to Ryan that the
contrast didn't pass WCAG guidelines, and he updated it in one of the
screens but not all of them.
—
Reply to this email directly, view it on GitHub
<#1148 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BBNX2D4LGC4RGY2XLBTT5AT2PEGYHAVCNFSM6AAAAABWW6YELWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBZGIYTEOBVHE>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for those changes! The code is looking great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
41740ff
to
dacddd8
Compare
Description
It is not reflected in the Figma design, but when a user is logged in or identified, we show a minimal version of the modals that doesn't include the left panel or header.
I've tested this thoroughly, but there are a lot of combinations of states, so it would be great to get another pair of eyes on it in case I missed something.
Testing
give-session
cookie to test the minimal mode of the sign in and sign up modals with a large and small screen width. (Or setthis.newUser = false
inregisterAccountModal.component.js
)$onInit
inregisterAccountModal.component.js
, addreturn this.stateChanged('contact-info')
to test the contact info modal with a large and small screen.registration-state
locally to test the user match modal.