Fix bugs in DSCEngineTest.t.sol: errors in calculating liquidation bonus amount. #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @0xEmiya, Thanks for this contribution. It will be addressed appropriately as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. There is a logical error in the way liquidation bonus amount are calculated in the UTs
testLiquidationPayoutIsCorrectandtestUserStillHasSomeEthAfterLiquidation. When you change theLIQUIDATION_BONUSto a number other than10, the tests will not pass (excluding hardcode assert fails).I tried to fix this issue, would you kindly review my changes?
Thanks