Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nice message from lperson #2362

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Conversation

lperson
Copy link
Contributor

@lperson lperson commented Sep 6, 2021

I rule and have completed some work on Case Manager that's ready for review!

This pull request makes the following changes:

  • I added a nice message to welcome_message_helper.rb

It relates to the following issue #s:

For reviewer:

  • Adjust the title to explain what it does for the notification email to the listserv.
  • Tag this PR:
    • feature if it contains a feature, fix, or similar. This is anything that contains a user-facing fix in some way, such as frontend changes, alterations to backend behavior, or bug fixes.
    • dependencies if it contains library upgrades or similar. This is anything that upgrades any dependency, such as a Gemfile update or npm package upgrade.
  • If it contains neither, no need to tag this PR.

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2021

Codecov Report

Merging #2362 (bcea5d5) into main (5403f04) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2362   +/-   ##
=======================================
  Coverage   96.24%   96.24%           
=======================================
  Files          79       79           
  Lines        1651     1651           
=======================================
  Hits         1589     1589           
  Misses         62       62           
Impacted Files Coverage Δ
app/helpers/welcome_message_helper.rb 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e3fb3c...bcea5d5. Read the comment docs.

@colinxfleming
Copy link
Member

welcome aboard @lperson !

@colinxfleming colinxfleming merged commit d22d7c1 into DARIAEngineering:main Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants