Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset timestamp col mapping #149

Merged
merged 3 commits into from
Dec 5, 2023
Merged

Conversation

Jami159
Copy link
Contributor

@Jami159 Jami159 commented Dec 5, 2023

For calibrate, in order to know which dataset column has timestamp, we're going to require the request body to have a mapping from the dataset column name to the 'timestamp' string. So for example the request body may look like

{
...
  "mappings": {
    <dataset timestamp column name:: "timestamp",
    <dataset column name 1>: <model state var 1>,
    <dataset column name 2>: <model state var 2>,
    ...
  }
...
}

@codecov-commenter
Copy link

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (7400ab4) 78.06% compared to head (65507dc) 77.56%.

Files Patch % Lines
src/SimulationService.jl 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
- Coverage   78.06%   77.56%   -0.51%     
==========================================
  Files           3        3              
  Lines         465      468       +3     
==========================================
  Hits          363      363              
- Misses        102      105       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jClugstor jClugstor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jClugstor jClugstor merged commit 7ddfed9 into main Dec 5, 2023
@jClugstor jClugstor deleted the dataset_timestamp_col_mapping branch December 5, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants