Ensemble refactor #153
Merged
Ensemble refactor #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I based this branch on another branch, which is why it has all of those commits that are already in main in there. I tried rebasing but it got weird very quickly :( . Anyway, the last 5 commits are the relevant ones in this case. |
joshday
reviewed
Dec 12, 2023
src/SimulationService.jl
Outdated
Comment on lines
221
to
228
| obj::JSON3.Object = JSON3.Object() # untouched JSON from request sent by HMI | ||
| id::String = "sciml-$(UUIDs.uuid4())" # matches DataServiceModel :id | ||
| route::String = "unknown" # :simulate, :calibrate, etc. | ||
| model::Union{Nothing, JSON3.Object} = nothing # ASKEM Model Representation (AMR) | ||
| models::Union{Nothing, Vector{JSON3.Object}} = nothing # Multiple models (in AMR) | ||
| timespan::Union{Nothing, NTuple{2, Float64}} = nothing # (start, end) | ||
| df::Union{Nothing, DataFrame} = nothing # dataset (calibrate only) | ||
| result::Any = nothing # store result of job |
There was a problem hiding this comment.
What is the diff here? I don't see any changes, right?
There was a problem hiding this comment.
I think I changed something here, then changed it back, but didn't change the spacing back. I'll fix that.
joshday
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.