Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make get_dataset get use tstep correctly when it's a symbol or a string. #156

Merged
merged 2 commits into from
Dec 16, 2023

Conversation

jClugstor
Copy link
Collaborator

No description provided.

@jClugstor jClugstor requested a review from joshday December 15, 2023 18:30
@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (dafde6f) 80.49% compared to head (05c1be0) 80.73%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/SimulationService.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
+ Coverage   80.49%   80.73%   +0.23%     
==========================================
  Files           3        3              
  Lines         482      488       +6     
==========================================
+ Hits          388      394       +6     
  Misses         94       94              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/SimulationService.jl Outdated Show resolved Hide resolved
@jClugstor jClugstor merged commit c292e1e into DARPA-ASKEM:main Dec 16, 2023
2 checks passed
@jClugstor jClugstor deleted the get_dataset_fix branch December 18, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants