Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terarium dataservice migration changes #158

Merged
merged 25 commits into from
Feb 7, 2024
Merged

terarium dataservice migration changes #158

merged 25 commits into from
Feb 7, 2024

Conversation

kbirk
Copy link
Contributor

@kbirk kbirk commented Jan 8, 2024

Hello

As you may be aware terarium has inherited the tds datraservice endpoints. Some changes have been made while integrating it with the existing backend.

Here is a small untested branch to assist in transitioning to the new endpoints. The changes are as follows:

  1. Request urls and query params are now kabob-case rather than snake_case.
  2. JSON keys are serialized / deserialized from camelCase rather than snake_case by default. Support for a "X-Enable-Snake-Case" header has been integrated which when provided will serialize / deserialize JSON keys as snake_case.
  3. All id fields are now uuid4 types and will be generated server side. Types have an optional human friendly name field as well.
  4. Our backend uses OAuth2 and many endpoints require a user object for ReBAC. For simplicity we have created a shared service-user that will be injected if the correct basic auth credential is added to each request. I've introduced TDS_USER and TDS_PASSWORD env vars that will be injected in a basic auth header in each request. Please contact our team and we will provide the credential for our staging env. Please do not commit the credential to the repo unencrypted.

Please let me know if there are any issues with this branch or you have any concerns. I apologize for any glaring issues with the work here, I am not familiar with Julia :)

Cheers

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (357c7e8) 84.40% compared to head (bc97604) 84.44%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/SimulationService.jl 68.75% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
+ Coverage   84.40%   84.44%   +0.04%     
==========================================
  Files           4        4              
  Lines         654      675      +21     
==========================================
+ Hits          552      570      +18     
- Misses        102      105       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/SimulationService.jl Outdated Show resolved Hide resolved
Copy link
Contributor

@dgauldie dgauldie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgauldie dgauldie merged commit 50823b8 into main Feb 7, 2024
2 checks passed
@dgauldie dgauldie deleted the dataservice-update branch February 7, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants