-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
terarium dataservice migration changes #158
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
==========================================
+ Coverage 84.40% 84.44% +0.04%
==========================================
Files 4 4
Lines 654 675 +21
==========================================
+ Hits 552 570 +18
- Misses 102 105 +3 ☔ View full report in Codecov by Sentry. |
…auth headers in where they were already included.
* breaking apart the headers encoding * removing prefix for uuid
I beleive that those values were undefined here. There may be better ways to do this, but, I'm not familar with Julia
one more try
This was referenced Feb 1, 2024
dgauldie
reviewed
Feb 1, 2024
dgauldie
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
As you may be aware
terarium
has inherited the tds datraservice endpoints. Some changes have been made while integrating it with the existing backend.Here is a small untested branch to assist in transitioning to the new endpoints. The changes are as follows:
kabob-case
rather thansnake_case
.camelCase
rather thansnake_case
by default. Support for a"X-Enable-Snake-Case"
header has been integrated which when provided will serialize / deserialize JSON keys assnake_case
.id
fields are nowuuid4
types and will be generated server side. Types have an optional human friendlyname
field as well.service-user
that will be injected if the correct basic auth credential is added to each request. I've introducedTDS_USER
andTDS_PASSWORD
env vars that will be injected in a basic auth header in each request. Please contact our team and we will provide the credential for our staging env. Please do not commit the credential to the repo unencrypted.Please let me know if there are any issues with this branch or you have any concerns. I apologize for any glaring issues with the work here, I am not familiar with Julia :)
Cheers