Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: Add preset to the Calibrate, Simulate and Optimize operator #4201

Closed
YohannParis opened this issue Jul 22, 2024 · 3 comments · Fixed by #4293 or #4322
Closed

[FEAT]: Add preset to the Calibrate, Simulate and Optimize operator #4201

YohannParis opened this issue Jul 22, 2024 · 3 comments · Fixed by #4293 or #4322
Assignees
Labels
feature New feature or request

Comments

@YohannParis
Copy link
Member

Design

image

Branch dev

main...TS/3433-speed-quality-button

value for the dropdown

To be filled by @liunelson

@YohannParis YohannParis added the feature New feature or request label Jul 22, 2024
@liunelson
Copy link
Member

liunelson commented Jul 22, 2024

There is some minor issues with the design of Calibrate:

  • The fields called "Number of samples" and "Solver method" stay as they are
  • There should be no "Number of global steps, number of local steps" field in the Settings section of Calibrate (those are for Optimize only)
  • Instead, there should be the following:
  1. A locked dropdown field called "Inference algorithm" with default value SVI
  2. A locked dropdown field called "Loss function" with default value ELBO (paired with "Inference algorithm")
  3. A locked dropdown field called "Optimizer" with default value Adam
  4. A numeric field called "Learning rate" with default value 0.03 (paired with "Optimizer")

Preset = Fast (i.e. Debug, Test, ? mode)

  • Number of samples = 1
  • Solver method = "euler"
  • Number of iterations = 10
  • Learning rate = 0.1

Preset = Precise (i.e. Serious, Evaluation, ? mode)

  • Number of samples = 100
  • Solver method = "dopri5"
  • Number of iterations = 1000
  • Learning rate = 0.03

Image

@liunelson liunelson changed the title [FEAT]: Add preset to the simulation operator [FEAT]: Add preset to the Calibrate operator Jul 22, 2024
@dvince2 dvince2 changed the title [FEAT]: Add preset to the Calibrate operator [FEAT]: Add preset to the Calibrate, Simulate and Optimize operator Jul 23, 2024
@dvince2 dvince2 linked a pull request Jul 26, 2024 that will close this issue
@liunelson
Copy link
Member

For Optimize, here are some defaults:

Preset = Fast (i.e. Debug, Test, ? mode)

Number of samples to evaluate constraints = 10
Number of samples to simulate model = 1
ODE solver method = "euler"
Number of global steps (maxiter) = 0
Number of local steps (maxfevals) = 1

Preset = Precise (i.e. Serious, Evaluation, ? mode)

Number of samples to evaluate constraints = 100
Number of samples to simulate model = 100
ODE solver method = "dopri5"
Number of global steps (maxiter) = 5
Number of local steps (maxfeval) = 25

@dvince2
Copy link
Collaborator

dvince2 commented Jul 30, 2024

Reopening for optimize

@dvince2 dvince2 reopened this Jul 30, 2024
@dvince2 dvince2 linked a pull request Jul 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
3 participants