Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4201 feat add preset to the calibrate and optimize operator #4293

Merged

Conversation

dvince2
Copy link
Collaborator

@dvince2 dvince2 commented Jul 26, 2024

Description

  • New options exposed for calibrate, as explained by Nelson in issue (this will need some under the hood wiring by @Tom-Szendrey )
  • New design to make calibrate and simulate look like optimize
  • Standardizing location for a number of enums.
  • Relocating the preset option in simulate, request by Pascale.

Note now Simulation and Calibration are done, but Optimize is still TODO

Resolves #(issue)

dvince2 added 4 commits July 24, 2024 15:28
* New options exposed for calibrate, as explained by Nelson in issue (this will need some under the hood wiring by Tom)
* New design to make calibrate and simulate look like optimize
* Standardizing location for a number of enums.
* Relocating the preset option in simulate, request by Pascale.
@Tom-Szendrey Tom-Szendrey requested a review from dgauldie as a code owner July 29, 2024 15:26
@dvince2 dvince2 requested a review from mwdchang July 29, 2024 17:58
dvince2 added 3 commits July 29, 2024 15:34
…brate-and-optimize-operator' into 4201-feat-add-preset-to-the-calibrate-and-optimize-operator
Copy link
Contributor

@Tom-Szendrey Tom-Szendrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please give me time to update the java types before merging this.
Corresponding changes will also be made here: DARPA-ASKEM/pyciemss-service#109

Copy link
Contributor

@Tom-Szendrey Tom-Szendrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have finished mucking around please test with these pyciemss-service updates:

DARPA-ASKEM/pyciemss-service#109

@Tom-Szendrey Tom-Szendrey merged commit 7a5e12a into main Jul 30, 2024
5 checks passed
@Tom-Szendrey Tom-Szendrey deleted the 4201-feat-add-preset-to-the-calibrate-and-optimize-operator branch July 30, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT]: Add preset to the Calibrate, Simulate and Optimize operator
4 participants