Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflow auto simulate orchestration changes #6309

Merged
merged 17 commits into from
Jan 30, 2025
Merged

workflow auto simulate orchestration changes #6309

merged 17 commits into from
Jan 30, 2025

Conversation

mwdchang
Copy link
Member

@mwdchang mwdchang commented Jan 30, 2025 •
edited
Loading

See:

Summary

Redo and consolidate the workflow changes in the last few days:

  • Fine grained port level updates to reduce the chance of collisions
  • Rework WorkflowWrapper#update to align with DB being the source of truth
  • Reduce layout changes that arise from scenario templates
  • WorkflowController clean up

Testing

  • Horizon scanning, or value-of-information scenario templates, workflow should not jump around or exhibits disconnected edges
  • Normal manual workflow operations (add/node/drag) should work

@mwdchang mwdchang mentioned this pull request Jan 30, 2025
Closed
@mwdchang mwdchang marked this pull request as ready for review January 30, 2025 18:40
@mwdchang mwdchang changed the title Workflow part4 workflow auto simulate orchestration chagnes Jan 30, 2025
@mwdchang mwdchang changed the title workflow auto simulate orchestration chagnes workflow auto simulate orchestration changes Jan 30, 2025
blanchco
blanchco approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@blanchco blanchco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested manually adding nodes in various ways as well as building templates. This is looking good!

@dgauldie dgauldie merged commit a1f8b3a into main Jan 30, 2025
8 checks passed
@dgauldie dgauldie deleted the workflow-part4 branch January 30, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YohannParis YohannParis YohannParis approved these changes

@blanchco blanchco blanchco approved these changes

@dgauldie dgauldie Awaiting requested review from dgauldie dgauldie is a code owner

@dvince2 dvince2 Awaiting requested review from dvince2 dvince2 is a code owner

@jryu01 jryu01 Awaiting requested review from jryu01 jryu01 is a code owner

@Tom-Szendrey Tom-Szendrey Awaiting requested review from Tom-Szendrey Tom-Szendrey is a code owner

@shawnyama shawnyama Awaiting requested review from shawnyama shawnyama is a code owner

@asylves1 asylves1 Awaiting requested review from asylves1 asylves1 is a code owner

@mloppie mloppie Awaiting requested review from mloppie mloppie is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mwdchang @YohannParis @blanchco @dgauldie