only print the first 10k in byte array to prevent log from blowing up #6582
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When exception happens in the fail over, we print out the bytes array stream, it is not particularly useful, especially if the content is large and it will completely overwhelm the server logging.
This PR caps to the first 10k bytes.
Testing
You can test this by uploading or viewing a very large AMR, eg the one that is 25MB from the eval. This will blow up the jackson serialization (a different issue) but also client-event. The byte-printing should last 2-3 pages and the actual useful exception trace is printed.