Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chart error caused by undefined passed to the date tooltip transform #6583

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Fix chart error caused by undefined passed to the date tooltip transform #6583

merged 1 commit into from
Feb 14, 2025

Conversation

jryu01
Copy link
Contributor

@jryu01 jryu01 commented Feb 13, 2025

Description

  • Fixed errors by making sure we don't pass undefined to calculate transform for the date tooltip.
  • Also reverted the changes that made value tooltip to show x value instead of y value

Resolves #(issue)

@jryu01 jryu01 marked this pull request as ready for review February 13, 2025 22:41
@mwdchang mwdchang merged commit 34fdc97 into main Feb 14, 2025
4 checks passed
@mwdchang mwdchang deleted the jryu/quick-fix-tooltip branch February 14, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YohannParis YohannParis YohannParis approved these changes

@mloppie mloppie mloppie approved these changes

@mwdchang mwdchang Awaiting requested review from mwdchang mwdchang is a code owner

@Tom-Szendrey Tom-Szendrey Awaiting requested review from Tom-Szendrey Tom-Szendrey is a code owner

@blanchco blanchco Awaiting requested review from blanchco blanchco is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jryu01 @YohannParis @mloppie @mwdchang