Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show rank charts in compare datasets node #6584

Merged
merged 4 commits into from
Feb 18, 2025

Conversation

blanchco
Copy link
Contributor

@blanchco blanchco commented Feb 14, 2025

Description

  • Show ranking charts in the compare datasets node

Took the opportunity to do some refactoring here:

  • state save on unmount instead of every knob change
  • added types where needed
  • moving the building the ranking chart to the useCharts.ts as done with the impact charts for consistency
  • Run no longer needed on ranking charts, they will calculate automatically when changes are made the the criteria cards

Copy link
Member

@mwdchang mwdchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't really test, code seems okay

@blanchco blanchco merged commit 8944cc0 into main Feb 18, 2025
4 checks passed
@blanchco blanchco deleted the show-rank-charts-in-compare-node branch February 18, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Ranking chart not shown on workflow node when ranking is selected in the "Compare dataset" operator
3 participants