Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better api-routing names #6594

Merged
merged 4 commits into from
Feb 18, 2025
Merged

better api-routing names #6594

merged 4 commits into from
Feb 18, 2025

Conversation

mwdchang
Copy link
Member

@mwdchang mwdchang commented Feb 18, 2025

Closes: #6489

Requires pyciemss-service changes: DARPA-ASKEM/pyciemss-service#137

Summary

Improve route names following resource standards

GET /models/from-model-configuration/:model-config-id => GET /model-configurations/:id/original-model
GET /model-configurations/as-configured-model/:config-id => GET /model-configurations/:id/model
PUT /model-configurations/as-configured-model => Remove, doesn't seem to be in use
POST /workflows/:id/node/:nodeId/selected-output/:outputId => POST /workflows/:id/node/:nodeId/output/:outputId

Testing

Should be able to run TA3 operators eg simulate, calibrate.

@mwdchang mwdchang marked this pull request as ready for review February 18, 2025 20:23
Copy link
Contributor

@Tom-Szendrey Tom-Szendrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test no complaints

@mwdchang mwdchang merged commit 16d02bf into main Feb 18, 2025
8 checks passed
@mwdchang mwdchang deleted the api-route-cleanup branch February 18, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK]: Reorganize confusing API routes
3 participants