Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6224 bug keep greek letters in extracted model somehow #6595

Merged

Conversation

YohannParis
Copy link
Member

@YohannParis YohannParis commented Feb 18, 2025

Description

  • Added extra var[...] names of greek letters.
  • Add a method to ModelService to clean up greek letters.

Resolves #6224

Testing

In a new create model from equations used the following LaTeX equations, and verify that the names of variables with a greek id have their name updated with a greek unicide character.

 \frac{d S(t)}{d t} = - \beta * S(t) * I(t) - \mu
 \frac{d I(t)}{d t} = \beta * S(t) * I(t) - \gamma * I(t) - \mu
 \frac{d R(t)}{d t} = \gamma * I(t) - \mu

Screenshot 2025-02-18 at 14 37 43

Copy link
Member

@liunelson liunelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the var* edge cases!

@liunelson liunelson merged commit 08397a7 into main Feb 18, 2025
5 checks passed
@liunelson liunelson deleted the 6224-bug-keep-greek-letters-in-extracted-model-somehow branch February 18, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Keep greek letters in extracted model somehow
3 participants