Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI annotation support for quantile charts #6598

Merged
merged 15 commits into from
Feb 20, 2025
Merged

Conversation

jryu01
Copy link
Contributor

@jryu01 jryu01 commented Feb 18, 2025

Description

  • Added chart annotation gollm prompt to support quantile charts
  • Added chartType property to ChartAnnotation model and also to the chart annotation task endpoint to tell the correct chart type for the llm generated annotation.
  • Some refactoring, renaming and clean ups (moved annotation related stuff from chart-settings.ts to chart-annotation.ts)
Screenshot 2025-02-18 at 3 43 32 PM Screenshot 2025-02-18 at 3 46 16 PM Screenshot 2025-02-18 at 3 46 30 PM

Resolves #6162

@jryu01 jryu01 marked this pull request as ready for review February 18, 2025 21:26
Copy link
Member

@mwdchang mwdchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested a few cases, looks okay!

@jryu01 jryu01 merged commit 670d6da into main Feb 20, 2025
9 checks passed
@jryu01 jryu01 deleted the jryu/quantil-chart-annotation branch February 20, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT]: Add AI-annotations to quantiles charts
3 participants