Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icon: remove icon round background (align with innertune) #170

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

mattcarter11
Copy link
Contributor

What is it?

  • New feature (user facing)
  • Update to existing feature (user facing)
  • Bugfix (user facing)
  • Translations
  • Codebase improvements or refactors (dev facing)
  • Other

Description of the changes in your PR

  • Remove round background in player buttons to align better with innertune and not distract

Before/After Screenshots/Screen Record

Due diligence

  • I read the contribution guidelines.
  • I understand that in the event of merge conflicts, I may be asked to rebase my branch on top of the dev branch, instead of resolving them by merging dev into my own branch

@mikooomich mikooomich requested a review from DD3Boh January 1, 2025 20:50
@mattcarter11 mattcarter11 force-pushed the remove-player-rounded-icon branch from 1e59706 to bb37c94 Compare January 3, 2025 15:52
@DD3Boh
Copy link
Owner

DD3Boh commented Jan 10, 2025

I'm worried about this possibly creating more contrast issues with gradient and blur backgrounds, since we support those as well.

@aqqlqlql
Copy link

I'm worried about this possibly creating more contrast issues with gradient and blur backgrounds, since we support those as well.

It will probably be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants