Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not process AMEND/DRAFT notifications #122

Merged
merged 4 commits into from
Feb 10, 2025
Merged

Do not process AMEND/DRAFT notifications #122

merged 4 commits into from
Feb 10, 2025

Conversation

t11omas
Copy link
Contributor

@t11omas t11omas commented Feb 6, 2025

This PR, updates the Notification pre processing to not process notifications that are in DRAFT or AMEND state.

We don't want to store DRAFTS, we want to wait until they are SUBMITTED.

We don't want to store AMEND, we want to wait until they are re submitted

@t11omas t11omas marked this pull request as ready for review February 6, 2025 15:40
Copy link

sonarqubecloud bot commented Feb 6, 2025

Copy link

github-actions bot commented Feb 6, 2025

Code Coverage

Package Line Rate Branch Rate Health
Btms.Consumers 86% 77%
Btms.Azure 43% 100%
Btms.Business 82% 73%
Btms.Types.Alvs.Mapping.V1.Tests 0% 0%
Btms.Types.Ipaffs 95% 62%
Btms.Types.Gvms 61% 100%
Btms.Types.Alvs.Mapping 81% 0%
Btms.Backend 62% 39%
Btms.Types.Gvms.Mapping 38% 25%
Btms.Model 91% 94%
Btms.Common 74% 56%
TestGenerator.IntegrationTesting.Backend 83% 71%
TestDataGenerator 86% 80%
Btms.Types.Ipaffs.Mapping 77% 50%
Btms.BlobService 39% 27%
Btms.Metrics 84% 0%
Btms.Backend.Data 64% 58%
Btms.Analytics 74% 73%
Btms.Types.Alvs 85% 67%
Btms.SensitiveData 79% 83%
Btms.SyncJob 63% 45%
Btms.Emf 11% 0%
Summary 78% (10072 / 12833) 62% (1014 / 1628)

@t11omas t11omas merged commit bac15e9 into main Feb 10, 2025
5 checks passed
@t11omas t11omas deleted the feature/cdms-133 branch February 10, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants