Adds implementation for local date time #123
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigedmunds
force-pushed
the
feature/local-date-time
branch
from
071d9d4 to
3b197f0
Compare
craigedmunds
force-pushed
the
feature/local-date-time
branch
from
9b2e790 to
e806e98
Compare
craigedmunds
force-pushed
the
feature/local-date-time
branch
from
e806e98 to
2bff8a2
Compare
tjpeel-ee
reviewed
Feb 7, 2025
|
|
||
| namespace Btms.Model; | ||
|
|
||
| public class LocalDateTimeJsonConverter : JsonConverter<DateTime> |
There was a problem hiding this comment.
Nit - naming of this as it means Local in terms of originating system. But perhaps such detail could be covered in the summary comment
tjpeel-ee
reviewed
Feb 7, 2025
|
|
||
| public override void Write(Utf8JsonWriter writer, DateTime value, JsonSerializerOptions options) | ||
| { | ||
| writer.WriteStringValue(value.ToString(JsonFormat, CultureInfo.InvariantCulture)); |
There was a problem hiding this comment.
I did mean to add logic to the converter I had, but we could enforce only an Unspecified DateTime value can be serialised here? Anything else would be unexpected and therefore an exception should be thrown
tjpeel-ee
reviewed
Feb 7, 2025
| "api/import-notifications?fields[import-notifications]=partOne"); | ||
|
|
||
| var expectedDateString = | ||
| $"\"departedOn\": \"{ExpectedDateTime:yyyy-MM-ddTHH:mm:ss}\""; |
There was a problem hiding this comment.
The edge case of not wanting seconds in relation to GVMS data still stands, although that can be an easy mod on top of the decisions made in this PR
tjpeel-ee
reviewed
Feb 7, 2025
|
|
||
| //Mongo stores things as UTC, not ideal but it is what it is! | ||
| result["cursor"]["firstBatch"][0]["partOne"]["departedOn"].ToString() | ||
| .Should().Be(ExpectedDateTime.ToString("yyyy-MM-ddTHH:mm:ssZ")); |
craigedmunds
changed the title
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some data we receive from source systems has no timezone information. Some data might be the timezone local to the person providing it, or that takes the action it relates to, or it might be related to where a consignment is at a point in time, and it could be anywhere in the world.
MongoDB stores all dates as datetimes with UTC timezone
We favour retaining strong typing in our internal model, and date related operations at the DB level so this change allows us to specify at the field level, and through the schema mapper code generator, those fields for which we expect to not know the timezone, so that we can convert them in and out of the database & JSON API correctly.