CDMS-146 changes the way MatchingService identifies non-linked docume… #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts - it should only expect CHEDs to be linked, not other documents such as IUU docs
craigedmunds
force-pushed
the
feature/cdms-146
branch
from
2008e8a to
eeeb2c6
Compare
t11omas
approved these changes
Jan 27, 2025
craigedmunds
force-pushed
the
feature/cdms-146
branch
2 times, most recently
from
0fac542 to
0283a49
Compare
craigedmunds
force-pushed
the
feature/cdms-146
branch
from
0283a49 to
dcd1fff
Compare
|
|
limsim
pushed a commit
that referenced
this pull request
Jan 27, 2025
#82) * CDMS-146 changes the way MatchingService identifies non-linked documents - it should only expect CHEDs to be linked, not other documents such as IUU docs * Need to handle lowercase * Fix sonarqube issue
limsim
pushed a commit
that referenced
this pull request
Jan 29, 2025
#82) * CDMS-146 changes the way MatchingService identifies non-linked documents - it should only expect CHEDs to be linked, not other documents such as IUU docs * Need to handle lowercase * Fix sonarqube issue
limsim
added a commit
that referenced
this pull request
Jan 29, 2025
* Added test data for test scenarios * CDMS-154 adds initialisation job to orchestrate all resource loading (#77) * CDMS-154 adds initialisation job to orchestrate all resource loading * Update DownloadCommand to handle multiple date folders * Improves SyncPeriodExtensions From202411 * Fix sonarqube issues * Track completion of notifications in initialisation job * Small refactor to reduce some duplicate code * updated syncjobstore to take in i logger --------- Co-authored-by: Thomas Anderson <[email protected]> * Updated job interceptor to use the consumer options retry count (#80) Co-authored-by: Thomas Anderson <[email protected]> * rebase * Fix mistake from merging. * CDMS-154 removes uneeded version related decision status. Adds some more test scenarios (#81) * CDMS-146 changes the way MatchingService identifies non-linked docume… (#82) * CDMS-146 changes the way MatchingService identifies non-linked documents - it should only expect CHEDs to be linked, not other documents such as IUU docs * Need to handle lowercase * Fix sonarqube issue * Feature/cdms 283 (#84) * updated decision service not to return a finder instead of throwing and exception, and added a test for the scenario * deleted test * fixed sonar and failing test * updated to make sure no exception is thrown --------- Co-authored-by: Thomas Anderson <[email protected]> * Changed the job counter to equals rather than greater than * CDMS-155 allows finalisedOnly to be passed to analytics endpoints to … (#83) * CDMS-155 allows finalisedOnly to be passed to analytics endpoints to filter on only those that have been finalised * CDMS-155 attempting to fix sonarqube 'too many arguments' error * Using AsParams * Fixing sonarqube * CDMS-156 adds integration tests for the three finalisation states (#88) * CDMS-156 adds integration tests for the three finalisation states * Fixed naming of classes * CDMS-156 Fixes typo iin bus concurrency config (#89) * This adds an endpoint to force the GC, it also updates the project to… (#87) * This adds an endpoint to force the GC, it also updates the project to use server GC mode which is more aggressive, and redacts the connection string * supressed warning --------- Co-authored-by: Thomas Anderson <[email protected]> * fix conflicts Update data and tests for IUU. * added test for all IUU ACs. * Fix conflict * Ensure months in sync paths are two digits (#90) * CDMS-153 adds tests for manual override (#91) * CDMS-215 fixes decision comparison issue impacting some environments (#92) * merge conflicts * rebase --------- Co-authored-by: Lim Sim <[email protected]> Co-authored-by: Craig Edmunds <[email protected]> Co-authored-by: Thomas Anderson <[email protected]> Co-authored-by: t11omas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nts - it should only expect CHEDs to be linked, not other documents such as IUU docs