add try catch to disconnect method (#52)

app/polling/poll.js

@@ -21,7 +21,11 @@ const poll = async () => {
     } catch (err) {
       console.error(err)
     } finally {
-      await disconnect(transfer.server)
+      try {
+        await disconnect(transfer.server)
+      } catch (disconnectError) {
+        console.error(`Disconnection from server ${transfer.server} failed: `, disconnectError)
+      }
     }
   }
 }

package.json

@@ -1,6 +1,6 @@
 {
   "name": "ffc-pay-gateway",
-  "version": "1.4.26",
+  "version": "1.4.27",
   "description": "Managed Gateway integration",
   "homepage": "https://github.com/DEFRA/ffc-pay-gateway",
   "main": "app/index.js",

test/unit/polling/poll.test.js

@@ -1,5 +1,7 @@
 jest.mock('../../../app/transfer')
+jest.mock('../../../app/sftp')
 const { getActiveTransfers, transferInboundFiles, transferOutboundFiles } = require('../../../app/transfer')
+const { connect, disconnect } = require('../../../app/sftp')
 
 const { INBOUND, OUTBOUND } = require('../../../app/constants/directions')
 
@@ -9,6 +11,8 @@ describe('poll', () => {
   beforeEach(() => {
     jest.clearAllMocks()
     getActiveTransfers.mockReturnValue([])
+    connect.mockResolvedValue()
+    disconnect.mockResolvedValue()
   })
 
   test('should get active transfers', async () => {
@@ -67,4 +71,13 @@ describe('poll', () => {
     await poll()
     expect(transferOutboundFiles).toHaveBeenCalledTimes(2)
   })
+
+  test('should continue to transfer files if disconnect throws error', async () => {
+    getActiveTransfers.mockReturnValueOnce([{ direction: INBOUND }, { direction: OUTBOUND }])
+    disconnect.mockImplementationOnce(() => { throw new Error() })
+    await poll()
+    expect(transferInboundFiles).toHaveBeenCalledTimes(1)
+    expect(transferOutboundFiles).toHaveBeenCalledTimes(1)
+    expect(disconnect).toHaveBeenCalledTimes(2)
+  })
 })