Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FCRM-5495 added appType internal/public and refactored tests #454

Merged
merged 14 commits into from
Jan 22, 2025
Merged

FCRM-5495 added appType internal/public and refactored tests #454

merged 14 commits into from
Jan 22, 2025

Conversation

markfee
Copy link
Collaborator

@markfee markfee commented Jan 21, 2025

No description provided.

markfee added 14 commits January 21, 2025 09:10
@markfee
FCRM-5495 copy helper ammended to show failures better
490a7fe
@markfee
FCRM-5495 /results now includes contacts and optin/optout status
0ee991f
@markfee
FCRM-5495 moved getContacts.spec.js
cf09d3a
@markfee
FCRM-5495 removed server dependency from getContacts.spec.js
ac64a78
@markfee
FCRM-5495 separated getContacts into getCustomerTeam and getLocalAuth…
7bed983 
…ority
@markfee
FCRM-5495 added tests for getEsriToken
e61162c
@markfee
FCRM-5495 added tests for esriRequest
858de5a
@markfee
FCRM-5495 added tests for getCustomerTeam
7428520
@markfee
FCRM-5495 added test coverage for server/services/agol/getContacts.js
a740a7c
@markfee
FCRM-5495 covered make...geometry functions
c53fafc
@markfee
Merge remote-tracking branch 'origin/release-3.0' into FCRM-5495
f6fcf42
@markfee
FCRM-5495 added a config for fmpAppType
6c54463
@markfee
FCRM-5495 Results page honours the appType==internal check when showi…
8a3dac0 
…ng the P4 button
@markfee
FCRM-5495 added appType to the payload for requestProductFour
edb9a25
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@markfee markfee requested a review from teddmason January 21, 2025 17:58
@markfee markfee merged commit dbf2b7d into release-3.0 Jan 22, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teddmason teddmason teddmason approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markfee @teddmason