Notifications review contacts formatting #1652
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4775 Previous work has been done to add the initial page, controller and router for the notification review page. This change refactors the existing licence contact document header contact formatting into a shared presenter. The notifications contact column will use this logic to give a consistent representation of the contact details to the user.
| @@ -0,0 +1,69 @@ | |||
| function _licenceContactAddress(contact) { | |||
| const contactAddressFields = [ | |||
There was a problem hiding this comment.
this needs testing
| @@ -17,6 +17,7 @@ const { db } = require('../../../../db/db.js') | |||
| */ | |||
| async function go(dueDate, summer) { | |||
| const { rows } = await _fetch(dueDate, summer) | |||
| // const { rows } = await _fetch('2024-11-28', 'true') | |||
There was a problem hiding this comment.
make sure to remove
| function _duplicateLicenceHolderAndReturnsToContact(acc, obj) { | ||
| const recipient = [acc[obj.contact_hash_id], obj].find((rec) => rec.message_type === 'Letter - licence holder') | ||
| const recipients = [acc[obj.contact_hash_id], obj].filter( |
There was a problem hiding this comment.
This assumes possible multiple licence holder and returns to having multiple types.
| @@ -84,8 +85,7 @@ FROM ( | |||
| ELSE 'Letter - returns to' | |||
| END) AS message_type, | |||
| (NULL) AS recipient, | |||
| LOWER( concat_ws(',', contacts->>'salutation', contacts->>'forename', contacts->>'initials', contacts->>'name', contacts->>'addressLine1', contacts->>'addressLine2', contacts->>'addressLine3', contacts->>'addressLine4', contacts->>'town', contacts->>'county', contacts->>'postcode', contacts->>'country')) | |||
| AS contact, | |||
| contacts as contact, | |||
There was a problem hiding this comment.
Seeing issues with some fields not being lowercased and showing as duplicates then they are (when lowercased properly)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4775
Previous work has been done to add the initial page, controller and router for the notification review page.
This change refactors the existing licence contact document header contact formatting into a shared presenter.
The notifications contact column will use this logic to give a consistent representation of the contact details to the user.