Add FetchDownloadRecipientsService #1678
Open
+323
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4776 As part of the work to implement notifications in the system repo we have a requirement to download the recipients data as a CSV. This change adds the required data for the CSV. This recipient list does not require deduplication as per previous work. And we can expect multiple rows per licence. However, we will still a registered licence contact over an unregistered licence. The controller / presenter / service will be added in a later change.
jonathangoulding
commented
Feb 3, 2025
| * If a licence is registered, we only extract the email contacts. Unregistered licences its the 'Licence holder' and | ||
| * 'Returns to' contacts from `licence_document_headers.metadata->contacts`. | ||
| * | ||
| * We have another service 'FetchContactsService' which removes duplicates rows by squashing them together. |
There was a problem hiding this comment.
Info for the reviewer - This js doc is similar to 'FetchContactsService' with this change added.
| SELECT | ||
| contacts.licence_ref, | ||
| contacts.contact_type, | ||
| contacts.return_reference, |
There was a problem hiding this comment.
I have mapped the return log data direct. I did not feel it necessary to prefix them with return_log but i can see an argument for return_log_start_date over just start_date.
happy to change or leave as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4776
As part of the work to implement notifications in the system repo we have a requirement to download the recipients data as a CSV.
This change adds the required data for the CSV. This recipient list does not require deduplication as per previous work. And we can expect multiple rows per licence.
However, we will still a registered licence contact over an unregistered licence.
The controller / presenter / service will be added in a later change.