Update LIBCXLTSP_CONFIGURATION_REPORT_PORTION_LEN to 0x200 #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxu9
changed the title
LIBCXLTSP_CONFIGURATION_REPORT_PORTION_LEN defines the portion length when reading the TSP_CONFIGURATION from device. Its value was 0x40 and was too small. Size of a request is limitted by LIBPCIDOE_SPDM_VENDOR_MAX_MESSAGE_SIZE which value is 0x400 (Refer to pci_doe_spdm_vendor_send_receive_data_ex). So it is reasonable to set the value of LIBCXLTSP_CONFIGURATION_REPORT_PORTION_LEN as 0x200. Signed-off-by: Min M Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #400
LIBCXLTSP_CONFIGURATION_REPORT_PORTION_LEN defines the portion length
when reading the TSP_CONFIGURATION from device. Its value was 0x40
and was too small.
Size of a request is limitted by LIBPCIDOE_SPDM_VENDOR_MAX_MESSAGE_SIZE
which value is 0x400 (Refer to pci_doe_spdm_vendor_send_receive_data_ex).
So it is reasonable to set the value of
LIBCXLTSP_CONFIGURATION_REPORT_PORTION_LEN as 0x200.