Testing Valueless PVL Keyword Issues (#5573)

* update Auto in .trn files * update Optional in .trn files * updated mission specific .trn files with Auto * updated Debug in .trn files * Account for valueless PVL keywords that are not reserved keywords * Added dummy values for MappingGroupKeywords.pft * Update all files that are weren't PVL compliant * Fixed missing 'Debug' flag * Missed a couple of test updates * Addressed PR feeback * Reverted if logic since keywordNameUpper is also const * Added break when searching for reserved keyword * reverted gtest * Added changelog entries for PVL updates --------- Co-authored-by: Amy Stamile <[email protected]>
DOI-USGS · Nov 15, 2024 · dd0bf99 · dd0bf99
1 parent 14c8162
commit dd0bf99
Show file tree

Hide file tree

Showing 311 changed files with 5,665 additions and 5,656 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -44,6 +44,8 @@ release.
 ### Changed
 - Refactored the pixel2map app
 - Updated pixel2map documentation
+- Changed PVL parsing to no longer allow valueless keywords [#5573](https://github.com/DOI-USGS/ISIS3/pull/5573)
+- Changed all `.trn` files with an `Auto`, `Debug` or `Optional` keyword with no value to have a value of `1` [#5573](https://github.com/DOI-USGS/ISIS3/pull/5573)
 
 ### Fixed
 - Fixed noseam bug where a debugging output statement was inadvertently left in noseam.cpp.

diff --git a/isis/appdata/serialnumbers/Apollo15MetricSerialNumber.trn b/isis/appdata/serialnumbers/Apollo15MetricSerialNumber.trn
@@ -1,5 +1,5 @@
 Group = Keyword1
-  Auto
+  Auto           = 1
   InputKey       = SpacecraftName
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)
@@ -9,7 +9,7 @@ Group = Keyword1
 End_Group
 
 Group = Keyword2
-  Auto
+  Auto           = 1
   InputKey       = InstrumentId
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)
@@ -19,7 +19,7 @@ Group = Keyword2
 End_Group
 
 Group = Keyword3
-  Auto
+  Auto           = 1
   InputKey       = StartTime
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)

diff --git a/isis/appdata/serialnumbers/Apollo15PanoramicSerialNumber.trn b/isis/appdata/serialnumbers/Apollo15PanoramicSerialNumber.trn
@@ -1,7 +1,7 @@
 ObservationKeys = 3
 
 Group = Keyword1
-  Auto
+  Auto           = 1
   InputKey       = SpacecraftName
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)
@@ -11,7 +11,7 @@ Group = Keyword1
 End_Group
 
 Group = Keyword2
-  Auto
+  Auto           = 1
   InputKey       = InstrumentId
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)
@@ -21,7 +21,7 @@ Group = Keyword2
 End_Group
 
 Group = Keyword3
-  Auto
+  Auto           = 1
   InputKey       = StartTime
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)

diff --git a/isis/appdata/serialnumbers/Apollo15SerialNumber.trn b/isis/appdata/serialnumbers/Apollo15SerialNumber.trn
@@ -1,5 +1,5 @@
 Group = Keyword1
-  Auto
+  Auto           = 1
   InputKey       = SpacecraftName
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)
@@ -9,7 +9,7 @@ Group = Keyword1
 End_Group
 
 Group = Keyword2
-  Auto
+  Auto           = 1
   InputKey       = InstrumentId
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)
@@ -19,7 +19,7 @@ Group = Keyword2
 End_Group
 
 Group = Keyword3
-  Auto
+  Auto           = 1
   InputKey       = SpacecraftClockCount
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)

diff --git a/isis/appdata/serialnumbers/Apollo16MetricSerialNumber.trn b/isis/appdata/serialnumbers/Apollo16MetricSerialNumber.trn
@@ -1,5 +1,5 @@
 Group = Keyword1
-  Auto
+  Auto           = 1
   InputKey       = SpacecraftName
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)
@@ -9,7 +9,7 @@ Group = Keyword1
 End_Group
 
 Group = Keyword2
-  Auto
+  Auto           = 1
   InputKey       = InstrumentId
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)
@@ -19,7 +19,7 @@ Group = Keyword2
 End_Group
 
 Group = Keyword3
-  Auto
+  Auto           = 1
   InputKey       = StartTime
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)

diff --git a/isis/appdata/serialnumbers/Apollo16PanoramicSerialNumber.trn b/isis/appdata/serialnumbers/Apollo16PanoramicSerialNumber.trn
@@ -1,7 +1,7 @@
 ObservationKeys = 3
 
 Group = Keyword1
-  Auto
+  Auto           = 1
   InputKey       = SpacecraftName
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)
@@ -11,7 +11,7 @@ Group = Keyword1
 End_Group
 
 Group = Keyword2
-  Auto
+  Auto           = 1
   InputKey       = InstrumentId
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)
@@ -21,7 +21,7 @@ Group = Keyword2
 End_Group
 
 Group = Keyword3
-  Auto
+  Auto           = 1
   InputKey       = StartTime
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)

diff --git a/isis/appdata/serialnumbers/Apollo17MetricSerialNumber.trn b/isis/appdata/serialnumbers/Apollo17MetricSerialNumber.trn
@@ -1,5 +1,5 @@
 Group = Keyword1
-  Auto
+  Auto           = 1
   InputKey       = SpacecraftName
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)
@@ -9,7 +9,7 @@ Group = Keyword1
 End_Group
 
 Group = Keyword2
-  Auto
+  Auto           = 1
   InputKey       = InstrumentId
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)
@@ -19,7 +19,7 @@ Group = Keyword2
 End_Group
 
 Group = Keyword3
-  Auto
+  Auto           = 1
   InputKey       = StartTime
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)

diff --git a/isis/appdata/serialnumbers/Apollo17PanoramicSerialNumber.trn b/isis/appdata/serialnumbers/Apollo17PanoramicSerialNumber.trn
@@ -1,7 +1,7 @@
 ObservationKeys = 3
 
 Group = Keyword1
-  Auto
+  Auto           = 1
   InputKey       = SpacecraftName
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)
@@ -11,7 +11,7 @@ Group = Keyword1
 End_Group
 
 Group = Keyword2
-  Auto
+  Auto           = 1
   InputKey       = InstrumentId
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)
@@ -21,7 +21,7 @@ Group = Keyword2
 End_Group
 
 Group = Keyword3
-  Auto
+  Auto           = 1
   InputKey       = StartTime
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)

diff --git a/isis/appdata/serialnumbers/CassiniIssSerialNumber.trn b/isis/appdata/serialnumbers/CassiniIssSerialNumber.trn
@@ -1,5 +1,5 @@
 Group = Keyword1
-  Auto
+  Auto           = 1
   InputKey       = SpacecraftName
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)
@@ -10,7 +10,7 @@ Group = Keyword1
 End_Group
 
 Group = Keyword2
-  Auto
+  Auto           = 1
   InputKey       = InstrumentId
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)
@@ -20,7 +20,7 @@ Group = Keyword2
 End_Group
 
 Group = Keyword3
-  Auto
+  Auto           = 1
   InputKey       = SpacecraftClockCount
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)

diff --git a/isis/appdata/serialnumbers/CassiniVimsSerialNumber.trn b/isis/appdata/serialnumbers/CassiniVimsSerialNumber.trn
@@ -1,5 +1,5 @@
 Group = Keyword1
-  Auto
+  Auto           = 1
   InputKey       = SpacecraftName
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)
@@ -10,7 +10,7 @@ Group = Keyword1
 End_Group
 
 Group = Keyword2
-  Auto
+  Auto           = 1
   InputKey       = InstrumentId
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)
@@ -20,7 +20,7 @@ Group = Keyword2
 End_Group
 
 Group = Keyword3
-  Auto
+  Auto           = 1
   InputKey       = Channel
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)
@@ -30,7 +30,7 @@ Group = Keyword3
 End_Group
 
 Group = Keyword4
-  Auto
+  Auto           = 1
   InputKey       = SpacecraftClockStartCount
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)

diff --git a/isis/appdata/serialnumbers/Chandrayaan1M3SerialNumber.trn b/isis/appdata/serialnumbers/Chandrayaan1M3SerialNumber.trn
@@ -1,7 +1,7 @@
 ObservationKeys = 2
 
 Group = Keyword1
-  Auto
+  Auto           = 1
   InputKey       = SpacecraftName
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)
@@ -12,7 +12,7 @@ Group = Keyword1
 End_Group
 
 Group = Keyword2
-  Auto
+  Auto           = 1
   InputKey       = InstrumentId
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)
@@ -22,7 +22,7 @@ Group = Keyword2
 End_Group
 
 Group = Keyword3
-  Auto
+  Auto           = 1
   InputKey       = StartTime
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)

diff --git a/isis/appdata/serialnumbers/Chandrayaan1MinirfSerialNumber.trn b/isis/appdata/serialnumbers/Chandrayaan1MinirfSerialNumber.trn
@@ -1,7 +1,7 @@
 ObservationKeys = 2
 
 Group = Keyword1
-  Auto
+  Auto           = 1
   InputKey       = SpacecraftName
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)
@@ -12,7 +12,7 @@ Group = Keyword1
 End_Group
 
 Group = Keyword2
-  Auto
+  Auto           = 1
   InputKey       = InstrumentId
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)
@@ -22,7 +22,7 @@ Group = Keyword2
 End_Group
 
 Group = Keyword3
-  Auto
+  Auto           = 1
   InputKey       = StartTime
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)

diff --git a/isis/appdata/serialnumbers/Clementine1HiresSerialNumber.trn b/isis/appdata/serialnumbers/Clementine1HiresSerialNumber.trn
@@ -1,5 +1,5 @@
 Group = Keyword1
-  Auto
+  Auto           = 1
   InputKey       = SpacecraftName
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)
@@ -11,7 +11,7 @@ Group = Keyword1
 End_Group
 
 Group = Keyword2
-  Auto
+  Auto           = 1
   InputKey       = InstrumentId
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)
@@ -21,7 +21,7 @@ Group = Keyword2
 End_Group
 
 Group = Keyword3
-  Auto
+  Auto           = 1
   InputKey       = StartTime
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)

diff --git a/isis/appdata/serialnumbers/Clementine1LwirSerialNumber.trn b/isis/appdata/serialnumbers/Clementine1LwirSerialNumber.trn
@@ -1,5 +1,5 @@
 Group = Keyword1
-  Auto
+  Auto           = 1
   InputKey       = SpacecraftName
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)
@@ -11,7 +11,7 @@ Group = Keyword1
 End_Group
 
 Group = Keyword2
-  Auto
+  Auto           = 1
   InputKey       = InstrumentId
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)
@@ -21,7 +21,7 @@ Group = Keyword2
 End_Group
 
 Group = Keyword3
-  Auto
+  Auto           = 1
   InputKey       = StartTime
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)

diff --git a/isis/appdata/serialnumbers/Clementine1NirSerialNumber.trn b/isis/appdata/serialnumbers/Clementine1NirSerialNumber.trn
@@ -1,5 +1,5 @@
 Group = Keyword1
-  Auto
+  Auto           = 1
   InputKey       = SpacecraftName
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)
@@ -11,7 +11,7 @@ Group = Keyword1
 End_Group
 
 Group = Keyword2
-  Auto
+  Auto           = 1
   InputKey       = InstrumentId
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)
@@ -21,7 +21,7 @@ Group = Keyword2
 End_Group
 
 Group = Keyword3
-  Auto
+  Auto           = 1
   InputKey       = StartTime
   InputGroup     = "IsisCube,Instrument"
   InputPosition  = (IsisCube, Instrument)