Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for 9.0.0 RC2 #5706

Merged
merged 4 commits into from
Jan 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ file. Slightly modified the FunctionalTestJigsawBundleXYZ ctest accordingly. Iss
- Fixed PHOTOMET not accepting backplanes [#5281](https://github.com/DOI-USGS/ISIS3/issues/5281)
- Fixed dstripe parallel test failing by converting tests to gtests [#5613](https://github.com/DOI-USGS/ISIS3/issues/5613)
- Fixed autoseed SeedDomain = SampleLine only working for first overlap [#5673](https://github.com/DOI-USGS/ISIS3/issues/5673)
- Fixed jigsaw to default OUTADJUSTMENTH5 option to false and allow this feature to run on read-only images [#5700](https://github.com/DOI-USGS/ISIS3/issues/5700)

## [8.3.0] - 2024-09-30

Expand Down
2 changes: 1 addition & 1 deletion isis/src/base/objs/Environment/Environment.truth
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
userName: eclipse
hostName: wang
version: isis8
version: isis9
2 changes: 1 addition & 1 deletion isis/src/control/apps/jigsaw/jigsaw.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ namespace Isis {
for (int i = 0; i < bundleAdjustment->numberOfImages(); i++) {
Process p;
CubeAttributeInput inAtt;
Cube *c = p.SetInputCube(bundleAdjustment->fileName(i), inAtt, ReadWrite);
Cube *c = p.SetInputCube(bundleAdjustment->fileName(i), inAtt, 0); // 0 for read only

// Only for ISIS adjustment values
if (!c->hasBlob("CSMState", "String")) {
Expand Down
11 changes: 6 additions & 5 deletions isis/src/control/apps/jigsaw/jigsaw.xml
Original file line number Diff line number Diff line change
Expand Up @@ -921,9 +921,6 @@
<default>
<item>No</item>
</default>
<exclusions>
<item>ADJUSTMENT_INPUT</item>
</exclusions>
</parameter>

<parameter name="OUTLIER_REJECTION">
Expand Down Expand Up @@ -1880,7 +1877,7 @@
</description>
<type>boolean</type>
<default>
<item>yes</item>
<item>no</item>
</default>
</parameter>

Expand All @@ -1898,6 +1895,11 @@
<filter>
*.h5
</filter>
<inclusions>
<item>
UPDATE
</item>
</inclusions>
<exclusions>
<item>ONET</item>
<item>CNET</item>
Expand All @@ -1907,7 +1909,6 @@
<item>SCCONFIG</item>
<item>OBSERVATIONS</item>
<item>RADIUS</item>
<item>UPDATE</item>
<item>OUTLIER_REJECTION</item>
<item>REJECTION_MULTIPLIER</item>
<item>ERRORPROPAGATION</item>
Expand Down
9 changes: 5 additions & 4 deletions isis/tests/FunctionalTestsJigsaw.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1875,20 +1875,21 @@ TEST_F(LidarNetwork, FunctionalTestJigsawLidar) {

TEST_F(ApolloNetwork, FunctionalTestJigsawSaveApplyValues) {
QVector<QString> args = {"spsolve=position",
"update=yes",
"update=no",
"bundleout_txt=no",
"cnet="+controlNetPath,
"fromlist="+tempDir.path() + "/cubes.lis",
"onet="+tempDir.path()+"/apollo_out.net",
"file_prefix="+tempDir.path()+"/"};
"file_prefix="+tempDir.path()+"/",
"outadjustmenth5=yes"};

UserInterface ui(APP_XML, args);

jigsaw(ui);

// Check apollo_jigsaw.h5 was created
QString bundleOutput = tempDir.path()+"/adjustment_out.h5";
HighFive::File file(bundleOutput.toStdString(), HighFive::File::ReadWrite);
HighFive::File file(bundleOutput.toStdString(), HighFive::File::ReadOnly);

std::string datasetName = "/APOLLO15/METRIC/1971-08-01T15:37:39.428";
QString cmatrixName = "InstrumentPointing";
Expand All @@ -1899,7 +1900,7 @@ TEST_F(ApolloNetwork, FunctionalTestJigsawSaveApplyValues) {
HighFive::DataSet datasetRead = file.getDataSet(cmatrixKey);
auto cmatrixData = datasetRead.read<std::string>();
Table cmatrixTable(cmatrixName, cmatrixData, ',');
std::string cmatrixTableStr = Table::toString(cmatrixTable).toStdString();
std::string cmatrixTableStr = Table::toString(cmatrixTable).toStdString();

datasetRead = file.getDataSet(spvectorKey);
auto spvectorData = datasetRead.read<std::string>();
Expand Down
4 changes: 2 additions & 2 deletions recipe/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
# A Public Release for ISIS3.6.1: {% set version = "3.6.1" %}
# A Release Candidate for ISIS3.6.1: {% set version = "3.6.1_RC" %}
# A custom build of ISIS3.6.1 for the CaSSIS mission: {% set version = "3.6.1_cassis" %}
{% set version = "8.3" %}
AustinSanders marked this conversation as resolved.
Show resolved Hide resolved
{% set version = "9.0" %}

# This is the build number for the current version you are building. If this is the first build of
# this version, the build number will be 0. It is incremented by 1 with every consecutive build of
Expand All @@ -27,7 +27,7 @@

package:
name: isis
version: {{ version }}.0_RC1
version: {{ version }}.0_RC2

source:
git_url: 'https://github.com/DOI-USGS/ISIS3.git'
Expand Down
Loading