Removed unused code identified by clang-tidy and me #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krlberry
commented
Jul 23, 2020
| return csm::ImageVector(m_nLines, m_nSamples); | ||
| } | ||
|
|
||
| //--------------------------------------------------------------------------- |
There was a problem hiding this comment.
Removed because this was commented-out, and getSensorModelState() was updated to getModelState() in the 3.0.3 version of the CSM API.
krlberry
commented
Jul 23, 2020
| (detectorSample + m_detectorSampleOrigin - m_startingDetectorSample) / | ||
| m_detectorSampleSumming; | ||
|
|
||
| double precision = |
There was a problem hiding this comment.
I removed this because it wasn't used, but I find the lack of any logic in here determining whether achievedPrecision is true or not confusing. Any ideas?
There was a problem hiding this comment.
The next block reports the final achieved precision.
krlberry
commented
Jul 23, 2020
| double& achieved_precision, | ||
| const double& desired_precision) const; | ||
|
|
||
| // Intersects the los with a specified plane. |
krlberry
commented
Jul 23, 2020
| @@ -521,7 +521,6 @@ csm::EcefCoord UsgsAstroSarSensorModel::imageToGround( | |||
| // Compute the spacecraft position in the new coordinate system | |||
| // The cross-track unit vector is orthogonal to the position so we ignore it | |||
| double nadirComp = dot(spacecraftPosition, tHat); | |||
| double inTrackComp = dot(spacecraftPosition, vHat); | |||
There was a problem hiding this comment.
@jessemapel Just want to double check that this wasn't needed in the calculation somewhere? It's not used right now.
There was a problem hiding this comment.
Nope I just rechecked Randy's notes and it's not used.
jessemapel
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed a focalPlaneY that should have been a focalPlaneX.
Also fixes logging file environment variable name #299.