[feat] 이용예정/완료 뷰 구현 #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Assignees랑 라벨 등등 설정해줍시다 |
jihyunniiii
reviewed
Nov 27, 2023
There was a problem hiding this comment.
고생해따 잘해따!
코드정렬 전체적으로 한 번 씩 해주시고 아래 사항들 신경써서 작업하면 좋을 것 같아오 !!
- 마진, 패딩 값은 최대한 작은 값으로 -> 근처에 있는 컴포넌트에 제약을 주자 !
- 스트링 추출은 꼭 필요한 경우에만 -> 서버에서 불러오는 값을 입력해줘야하는 등 값이 계속 변경되는 텍스트의 경우에는 tools를 활용해서 미리보기를 하자 !
- 고정 높이, 너비 값을 주는 건 좋지 않움 ! 불가피한 상황이 아니라면 wrap_content, match_parent, 0dp를 사용하자
- 코드정렬, 불필요한 임포트 제거는 필수!!!
app/src/main/java/org/sopt/tabling/data/model/request/RequestOrdersDto.kt
Outdated
Show resolved
Hide resolved
| import org.sopt.tabling.databinding.FragmentQueueCancelBinding | ||
|
|
||
|
|
||
| class QueueCancelFragment : Fragment() { |
There was a problem hiding this comment.
BindingFragment 사용해줍시당
There was a problem hiding this comment.
BindingFragment 사용해줍시당
잘,, 모르게쑵니다 넘 바빠서ㅜㅜㅜㅜ 학교 프젝 끝나구 찬찬히 공부해바도 될까여 엉엉😱😱😱
| import org.sopt.tabling.databinding.FragmentQueueReservationBinding | ||
| import org.sopt.tabling.presentation.common.ReservationViewModel | ||
|
|
||
| class QueueReservationFragment : Fragment() { |
|
|
||
| fun setReservationList(mockReservationList: List<ReservationItem>) { | ||
| reservationList = mockReservationList | ||
| notifyDataSetChanged() |
There was a problem hiding this comment.
지은이두 !! 합세 끝나고 나중에라두 diffutil이랑 listAdapter 공부해보고 적용해보깅 !
There was a problem hiding this comment.
지은이두 !! 합세 끝나고 나중에라두 diffutil이랑 listAdapter 공부해보고 적용해보깅 !
넵!@!@@!첨 들어보는 군여.... 앱잼 전에 공부 마니마니 해야겟다
|
민우오빠가 머지한 거 있어서 디벨롭 업데이트 하구 merge develop into feat_queue_details 해야할 것 같네옹 !! |
Doreminwoo
approved these changes
Nov 27, 2023
app/src/main/java/org/sopt/tabling/data/model/request/RequestOrdersDto.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/sopt/tabling/presentation/queue/QueueDetailsActivity.kt
Outdated
Show resolved
Hide resolved
| private var reservationList: List<ReservationItem> = emptyList() | ||
| override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): RecyclerView.ViewHolder { | ||
| return when (viewType) { | ||
| 1 -> ReservationViewHolder( |
Comment on lines
109
to
128
| <TextView | ||
| android:id="@+id/tv_waiting" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:layout_marginStart="23dp" | ||
| android:layout_marginTop="108dp" | ||
| android:text="@string/queue_tv_waiting" | ||
| android:textAppearance="@style/TextAppearance.H0" | ||
| android:textColor="@color/primary" | ||
| app:layout_constraintStart_toStartOf="parent" | ||
| app:layout_constraintTop_toTopOf="parent" /> | ||
|
|
||
| <TextView | ||
| android:id="@+id/tv_waiting_num" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:layout_marginTop="108dp" | ||
| android:text="@string/queue_tv_waiting_num" | ||
| android:textAppearance="@style/TextAppearance.H0" | ||
| android:textColor="@color/primary" |
Closed
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work Description ✏️
Screenshot 📸
Uncompleted Tasks 😅
To Reviewers 📢