[feat] 대기 신청 완료 팝업 구현 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
jihyunniiii
requested review from
Doreminwoo and
jihyunniiii
and removed request for
Doreminwoo
jihyunniiii
reviewed
Nov 27, 2023
|
|
||
| binding.btnGogogo.setOnClickListener{ | ||
| WaitingDialog().show( | ||
| supportFragmentManager, "WaitingDialog" |
There was a problem hiding this comment.
요거 companion object로 상수 추출해줘두 좋을 듯 !
| android:id="@+id/btn_gogogo" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:text="이거 누르면 다이얼로그 띄워짐 유후" |
Comment on lines
118
to
145
| <TextView | ||
| android:id="@+id/tv_dialog_now_waiting" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:layout_marginStart="0dp" | ||
| android:layout_marginTop="17dp" | ||
| android:text="@string/tv_dialog_now_waiting" | ||
| android:textAppearance="@style/TextAppearance.Caption1.SemiBold" | ||
| android:textColor="@color/primary" | ||
| app:layout_constraintStart_toEndOf="@+id/imv_ic_info_24" | ||
| app:layout_constraintTop_toBottomOf="@+id/cons_waiting_number" /> | ||
|
|
||
| <TextView | ||
| android:id="@+id/tv_dialog_now_waiting_number" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:layout_marginStart="4dp" | ||
| android:layout_marginTop="17dp" | ||
| android:text="@string/tv_dialog_now_waiting_number" | ||
| android:textAppearance="@style/TextAppearance.Caption1.SemiBold" | ||
| android:textColor="@color/primary" | ||
| app:layout_constraintStart_toEndOf="@+id/tv_dialog_now_waiting" | ||
| app:layout_constraintTop_toBottomOf="@+id/cons_waiting_number" /> | ||
|
|
||
| <TextView | ||
| android:id="@+id/tv_dialog_now_waiting2" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" |
There was a problem hiding this comment.
얘네도 하나의 텍스트뷰로 만들어요!
오호 텍스트뷰도 중첩이 가능하군여
Comment on lines
+177
to
+188
| <TextView | ||
| android:id="@+id/tv_dialog_store_output" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:layout_marginTop="12dp" | ||
| android:layout_marginEnd="12dp" | ||
| android:text="@string/tv_dialog_store_output" | ||
| android:textAppearance="@style/TextAppearance.Body2.SemiBold" | ||
| android:textColor="@color/gray_300" | ||
| app:layout_constraintEnd_toEndOf="parent" | ||
| app:layout_constraintTop_toTopOf="parent" /> | ||
|
|
There was a problem hiding this comment.
이거 2명 이것도 나누지 말고 하나의 텍스트뷰 사용해주세요
There was a problem hiding this comment.
이거 2명 이것도 나누지 말고 하나의 텍스트뷰 사용해주세요
이거.. 제가 데이터바인딩을 안 써서 그런지 안되는 것 같은데 지금 일단 급한 컴파일 오류부터 수정할게요 jdk 바꿔서 큰일난거같아여 ㅜ ㅜ
Doreminwoo
approved these changes
Nov 27, 2023
| android:layout_marginTop="16dp" | ||
| android:layout_marginEnd="16dp" | ||
| android:background="@drawable/shape_gray_600_fill_4" | ||
| android:minWidth="272dp" |
…iting-popup # Conflicts: # app/src/main/AndroidManifest.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work Description ✏️
Screenshot 📸
Uncompleted Tasks 😅
To Reviewers 📢