[faet] 대기 상세 화면 API 구현 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
5 tasks
|
얘도 아래 이슈들 필수적으로 해결하고 머지해주세영
|
|
orderId는 제가 화면 연결하면서 넘겨주께용 요건 아직 신경쓰지 않아두 될 것 가타오 |
jihyunniiii
approved these changes
Nov 29, 2023
| fun getWaitingDetail(orderId: Int) { | ||
| viewModelScope.launch { | ||
| val response = | ||
| kotlin.runCatching { ServicePool.waitingDetailService.getWaitingDetail(orderId) } |
There was a problem hiding this comment.
Suggested change
| kotlin.runCatching { ServicePool.waitingDetailService.getWaitingDetail(orderId) } | |
| runCatching { ServicePool.waitingDetailService.getWaitingDetail(orderId) } |
지워줘두 됩니둥
HAJIEUN02
approved these changes
Nov 30, 2023
| 0, | ||
| "맛있어요", | ||
| ) | ||
| fun getWaitingDetail(orderId: Int) { |
There was a problem hiding this comment.
하 뷰모델에서 서버통신하는 거 이거 넘 탐나구 넘 하고 싶은데욥 이번 주 세미나 때 열공빡공해보겠습니다
| @@ -60,7 +62,7 @@ | |||
| android:layout_marginTop="3dp" | |||
| android:text="@{@string/waiting_number_primary(waitingData.waitingNumber)}" | |||
| android:textAppearance="@style/TextAppearance.H2" | |||
| android:textColor="@color/primary" | |||
| android:textColor="@{waitingData.orderStatus == @string/waiting_status_ing ? @color/primary : @color/gray_100}" | |||
There was a problem hiding this comment.
오호라 다 바꾸셨군요.. 세미나를 안 듣고 어떻게 이렇게 딱 세미나에 맞게 하시는 건지 대단합니다링
| app:layout_constraintEnd_toStartOf="@+id/btn_waiting_detail_location" | ||
| app:layout_constraintHorizontal_bias="0.5" | ||
| app:layout_constraintHorizontal_chainStyle="packed" |
There was a problem hiding this comment.
왕 이건 첨보네요 packed!! bias 0.5도 나쁘지 않다고 생각하는데 이걸로 바꾼 이유가 있나요?
There was a problem hiding this comment.
사실 상 layout_constraintHorizontal_bias="0.5"는 필요 없어서 지워주는 게 낫습니당
packed는 체인 속성을 준 거예요 !
constraintLayout에는 체인이라는 게 있는데 요거 한 번 공부해보면 좋을 것 같네용
체인을 적절히 잘 쓰면 뷰 구현하는 게 좀 편리한 것 같아요 (개인적 생각,,)
| app:layout_constraintStart_toStartOf="parent" | ||
| app:layout_constraintTop_toBottomOf="@id/tv_waiting_detail_number" /> | ||
|
|
||
| <Button | ||
| android:id="@+id/btn_waiting_detail_location" | ||
| style="@style/Style.Material3.Button.Outlined.Custom" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="0dp" | ||
| android:layout_width="0dp" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work Description ✏️
Screenshot 📸
Uncompleted Tasks 😅
To Reviewers 📢