Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] 매장 상세 뷰 api 연동 #23

Merged
merged 10 commits into from
Nov 29, 2023
Merged

[feat] 매장 상세 뷰 api 연동 #23

merged 10 commits into from
Nov 29, 2023

Conversation

jihyunniiii
Copy link
Contributor

@jihyunniiii jihyunniiii commented Nov 29, 2023 •
edited
Loading

Related issue 🛠

Work Description ✏️

  • 매장 상세 뷰 api를 연동하였습니다.
  • dummy 파일을 삭제하였습니다.
  • 코드리뷰를 반영하여 로직을 수정하였습니다. (Adapter 해제, 동적 칩 추가 로직 수정, setShopDetailRecentReview 로직 수정)

Screenshot 📸

Screen_recording_20231129_170432.mp4

Uncompleted Tasks 😅

  • N/A

To Reviewers 📢

끝이 보인당 ㅠㅠ
지은이 민우오빠 팟팅 !!

@jihyunniiii jihyunniiii added this to the API 연동 milestone Nov 29, 2023
@jihyunniiii jihyunniiii self-assigned this Nov 29, 2023
HAJIEUN02
HAJIEUN02 approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@HAJIEUN02 HAJIEUN02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

급해보이니까 어프룹부터 달구 찬찬히 읽어볼게여

Doreminwoo
Doreminwoo approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@Doreminwoo Doreminwoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

너무너무 고생하셨습니다!
마무리까지 아자자!

app/src/main/java/org/sopt/tabling/data/model/response/ResponseShopDetailDto.kt
import org.sopt.tabling.domain.model.ShopDetail

@Serializable
data class ResponseShopDetailDto(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와 response 엄청 많네요....

@jihyunniiii jihyunniiii merged commit 103e8dd into develop Nov 29, 2023
1 check passed
@Doreminwoo Doreminwoo deleted the feat-shop-detail-api-connection branch December 26, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Doreminwoo Doreminwoo Doreminwoo approved these changes

@HAJIEUN02 HAJIEUN02 HAJIEUN02 approved these changes

Assignees

@jihyunniiii jihyunniiii

Labels
🐸 지현 🐸 💫 feat 💫
Projects
Tabling-AOS
Status: Done
Milestone
API 연동
Development

Successfully merging this pull request may close these issues.

[feat] 매장 상세 뷰 api 연동
3 participants
@jihyunniiii @HAJIEUN02 @Doreminwoo