[feat] 방문 인원 모달 api 연동 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/main/java/org/sopt/tabling/presentation/shopDetail/ShopDetailActivity.kt
HAJIEUN02
approved these changes
Nov 30, 2023
| @SerialName("order_status") | ||
| val orderStatus: String | ||
| ) { | ||
| fun toReserve() = Reserve( |
There was a problem hiding this comment.
이거는 어떤 식으로 작동하는 건가여?? 바인딩 같은 건가욥
There was a problem hiding this comment.
클린 아키텍처를 적용하기 위해 구현한 매퍼입니당!!
data 계층에 있는 data class를 domain 계층의 data class로 바꿔주어요
| suspend fun postReserve( | ||
| shopId: Long, | ||
| personCount: Int | ||
| ): Result<Reserve?> |
There was a problem hiding this comment.
Reserve뒤에 ?는 null 처리 때문인가용?
There was a problem hiding this comment.
넹 맞습니당
BaseResponse를 사용하였는데 BaseResponse의 data 값이 null이 될 수 있어서 저렇게 선언했어용
| } | ||
|
|
||
| private fun collectData() { | ||
| reserveViewModel.personCount.flowWithLifecycle(viewLifecycleOwner.lifecycle) |
There was a problem hiding this comment.
키킼 라이브 데이터 마스터하구 플로우 공부해보세영
| binding.ivReservePlus.load( | ||
| when (reserveViewModel.personCount.value) { | ||
| PERSON_LAST_VALUE.toString() -> R.drawable.ic_plus_gray_100_24 | ||
| else -> R.drawable.ic_plus_black_24 |
There was a problem hiding this comment.
이런 식으로 drawable 교체해주는 방법 좋은 것 같숨다.. 이번 학교 프젝에서 쓸 일이 많아서 참고하겠슴당 헤헤
There was a problem hiding this comment.
when문을 적절히 잘 쓰면 가독성이 조아지는 것 가타요
| android:text="@string/tv_waiting_number" | ||
| android:textAppearance="@style/TextAppearance.H0" | ||
| android:textColor="@color/white" | ||
| app:layout_constraintBottom_toBottomOf="@+id/tv_waiting_number_text" |
There was a problem hiding this comment.
우하하 @+id 발견 자동완성 금지~~~~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
Screen_recording_20231130_032148.mp4
Uncompleted Tasks 😅
To Reviewers 📢
칭찬해주면 안 졸고 열심히 할 수 있을 것 가타,,,
칭찬해조,, 나 너무 졸려 z.z