[feat] 이용예정/완료 API 연동 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
7 tasks
HAJIEUN02
assigned Doreminwoo and jihyunniiii and unassigned Doreminwoo and jihyunniiii
jihyunniiii
approved these changes
Dec 1, 2023
Comment on lines
+8
to
+13
| @SerialName("code") | ||
| val code: Int, | ||
| @SerialName("message") | ||
| val message: String, | ||
| @SerialName("data") | ||
| val data: Data, |
There was a problem hiding this comment.
저희 api 명세서 보면 code, message, data 이 세 개는 모든 response에 동일하게 존재하는데요
그렇기 때문에 얘네를 BaseResponse로 만들어 사용할 수 있습니당
저는 BaseResponse를 이용해서 작업했어용
코드 한 번 참고해보시면 좋을 것 같네요
| } | ||
|
|
||
| override fun onFailure(call: Call<ResponseReservationDto>, t: Throwable) { | ||
| context!!.showToast("네트워크 에러 발생") |
There was a problem hiding this comment.
Suggested change
| context!!.showToast("네트워크 에러 발생") | |
| Log.e("network", t.message.toString()) |
이런 식으로 토스트 메시지를 이용하는 게 아니라 내려오는 오류 값을 로그를 통해 찍어보면 어떤 것 때문에 실패했는지 알 수 있어서 좋아요
| if (response.isSuccessful) { | ||
| val data: ResponseApplyCodeDto = response.body()!! | ||
| if (response.code() == 400) { | ||
| context!!.showToast("이미 이용 완료된 주문입니다.") |
There was a problem hiding this comment.
나중에 요런 것도 스트링 추출이나 상수화 해주면 좋을 듯요
| private val inflater by lazy { LayoutInflater.from(context) } | ||
|
|
||
| private var reservationList: List<ReservationItem> = emptyList() | ||
| private var reservationList: List<ResponseReservationDto.Reservation> = emptyList() | ||
|
|
||
| override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): RecyclerView.ViewHolder { | ||
| return when (viewType) { | ||
| 1 -> ReservationViewHolder( |
Comment on lines
+48
to
+56
| if (reservationList[position].orderStatus == "이용 예정") { | ||
| return 1 | ||
| } else if (reservationList[position].orderStatus == "이용 완료") { | ||
| if (reservationList[position].remainingReviewPeriod <= 0) { | ||
| return 3 | ||
| } | ||
| return 2 | ||
| } else { | ||
| return 1 |
There was a problem hiding this comment.
여기 when문을 사용한다면 가독성이 더 좋아질 것 같아오
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work Description ✏️
Screenshot 📸
Uncompleted Tasks 😅
To Reviewers 📢
드디어 합세 끝..
버튼에 이미지 넣어야 되는데 지금까지 뷰에 빼먹었더라구욥
이걸 방금 전에 알아서ㅜ.ㅜ 야매로 이미지 집어넣었습니다 패딩 잔뜩 넣어서..
쩝 기기대응이 될지 모르겠어요
함 봐쥬세용!! item_none_reservation.xml 파일임미다