Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Use uv as package manager #2168

Merged
merged 1 commit into from
Feb 7, 2025
Merged

build: Use uv as package manager #2168

merged 1 commit into from
Feb 7, 2025

Conversation

MoritzWeber0
Copy link
Member

No description provided.

Copy link

github-actions bot commented Feb 5, 2025

API Changelog 4.16.1.dev18+g7d8e8776

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.11%. Comparing base (f9acd90) to head (ee94cb5).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2168      +/-   ##
==========================================
- Coverage   87.51%   87.11%   -0.41%     
==========================================
  Files         238      238              
  Lines        8172     8391     +219     
  Branches      571      613      +42     
==========================================
+ Hits         7152     7310     +158     
- Misses        858      909      +51     
- Partials      162      172      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 5, 2025

A Storybook preview is available for commit 185c822.
➡️ View Storybook
➡️ View Chromatic build

Base automatically changed from python-312 to main February 6, 2025 13:45
@MoritzWeber0 MoritzWeber0 changed the title Use uv build: Use uv as package manager Feb 6, 2025

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@MoritzWeber0 MoritzWeber0 requested a review from zusorio February 6, 2025 15:41
@MoritzWeber0 MoritzWeber0 marked this pull request as ready for review February 6, 2025 15:41

This comment has been minimized.

Copy link
Member

@zusorio zusorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readthedocs is still using pip instead of uv (and the backend but that's addressed by a separate PR). Py-capellambse already uses uv for building Readthedocs, you can check that out as an example.

@MoritzWeber0
Copy link
Member Author

MoritzWeber0 commented Feb 7, 2025

Readthedocs is still using pip instead of uv (and the backend but that's addressed by a separate PR). Py-capellambse already uses uv for building Readthedocs, you can check that out as an example.

The overhead of installing uv is probably larger than the few packages we install via pip. The Python packages are cached in readthedocs, not sure if that would still work with uv. I would also leave the installation to readthedocs, they will use what makes the most sense to them, maybe they'll switch to uv in the future.

EDIT: If there's a need, we can change it in a follow-up PR.

Copy link

sonarqubecloud bot commented Feb 7, 2025

Copy link

github-actions bot commented Feb 7, 2025

This report was generated by comparing 7d8e877 with f9acd90.
If you would like to check difference, please check here.

change detected

ArtifactName: reg

item count
pass 448
change 10
new 0
delete 0
📝 Report

Differences

Code Block With Job ID_desktop.png

actual Actual
expected Expected
difference Difference

Code Block With Job ID_mobile.png

actual Actual
expected Expected
difference Difference

Code Block With Token_desktop.png

actual Actual
expected Expected
difference Difference

Code Block With Token_mobile.png

actual Actual
expected Expected
difference Difference

Code Block_desktop.png

actual Actual
expected Expected
difference Difference

Code Block_mobile.png

actual Actual
expected Expected
difference Difference

Files_desktop.png

actual Actual
expected Expected
difference Difference

Files_mobile.png

actual Actual
expected Expected
difference Difference

Upload New File_desktop.png

actual Actual
expected Expected
difference Difference

Upload New File_mobile.png

actual Actual
expected Expected
difference Difference

@MoritzWeber0 MoritzWeber0 merged commit 67f8d67 into main Feb 7, 2025
31 checks passed
@MoritzWeber0 MoritzWeber0 deleted the use-uv branch February 7, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants