fix: Revoke T4C session tokens for initial repositories #2191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2191 +/- ##
==========================================
+ Coverage 87.62% 87.65% +0.02%
==========================================
Files 240 240
Lines 8268 8285 +17
Branches 568 571 +3
==========================================
+ Hits 7245 7262 +17
Misses 863 863
Partials 160 160 ☔ View full report in Codecov by Sentry. |
API Changelog 4.18.2.dev10+g5616ee92 |
This comment has been minimized.
This comment has been minimized.
MoritzWeber0
force-pushed
the
revoke-session-tokens-rewrite
branch
from
2dd98a4 to
464e9a6
Compare
Bundle ReportBundle size has no change ✅ |
This comment has been minimized.
This comment has been minimized.
Instead of evaluating the repository list during termination again, save the repositories with issued tokens in the database and revoke the tokens for exactly the same repositories.
MoritzWeber0
force-pushed
the
revoke-session-tokens-rewrite
branch
from
464e9a6 to
3740761
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of evaluating the repository list during termination again, save the repositories with issued tokens in the database and revoke the tokens for exactly the same repositories.