Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle unauthorized requests to Grafana or Prometheus #2202

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

MoritzWeber0
Copy link
Member

If the session token expires, nginx just showed "401 Unauthorized". Instead, redirect to the login page and after login back to the original URL.

Copy link

codecov bot commented Feb 13, 2025

Bundle Report

Changes will increase total bundle size by 144 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
capella-collab-manager-esm 13.92MB 144 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: capella-collab-manager-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 144 bytes 2.73MB 0.01%

Files in assets/index-*.js:

  • ./src/app/general/auth/auth/auth.component.ts → Total Size: 6.09kB

  • ./src/app/general/auth/auth-redirect/auth-redirect.component.ts → Total Size: 4.12kB

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.45%. Comparing base (ee35ef4) to head (5ab8a37).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2202      +/-   ##
==========================================
- Coverage   87.53%   87.45%   -0.08%     
==========================================
  Files         239      239              
  Lines        8208     8220      +12     
  Branches      572      573       +1     
==========================================
+ Hits         7185     7189       +4     
- Misses        862      870       +8     
  Partials      161      161              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This comment has been minimized.

Copy link

github-actions bot commented Feb 13, 2025

A Storybook preview is available for commit 2d02e5e.
➡️ View Storybook
➡️ View Chromatic build

@MoritzWeber0 MoritzWeber0 requested a review from zusorio February 13, 2025 09:34
If the session token expires, nginx just showed "401 Unauthorized".
Instead, redirect to the login page and after login back to the original URL.
Copy link

This report was generated by comparing 2d02e5e with ee35ef4.
If you would like to check difference, please check here.

success

ArtifactName: reg

✨✨ That's perfect, there is no visual difference! ✨✨

item count
pass 464
change 0
new 0
delete 0

@MoritzWeber0 MoritzWeber0 merged commit c211b6b into main Feb 13, 2025
33 checks passed
@MoritzWeber0 MoritzWeber0 deleted the auth-redirects branch February 13, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants